]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tracing: Fix memory leak in set_trigger_filter()
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Mon, 10 Dec 2018 02:17:30 +0000 (21:17 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Dec 2018 13:09:51 +0000 (14:09 +0100)
commit60ed7a77f8f90ba93fc12f8ddb86751fe8817428
tree674658e54ef362edac1d184aa51b5f74d9341768
parentc046fa1ca387f39a4774eda5a825a0e1902ab6f8
tracing: Fix memory leak in set_trigger_filter()

commit 3cec638b3d793b7cacdec5b8072364b41caeb0e1 upstream.

When create_event_filter() fails in set_trigger_filter(), the filter may
still be allocated and needs to be freed. The caller expects the
data->filter to be updated with the new filter, even if the new filter
failed (we could add an error message by setting set_str parameter of
create_event_filter(), but that's another update).

But because the error would just exit, filter was left hanging and
nothing could free it.

Found by kmemleak detector.

Cc: stable@vger.kernel.org
Fixes: bac5fb97a173a ("tracing: Add and use generic set_trigger_filter() implementation")
Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/trace/trace_events_trigger.c