]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
EVM: Use crypto_memneq() for digest comparisons
authorRyan Ware <ware@linux.intel.com>
Thu, 11 Feb 2016 23:58:44 +0000 (15:58 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Feb 2016 20:34:39 +0000 (12:34 -0800)
commit6121dabef629c5b584abd617bba87f420b7f4011
tree53fe9c3d8e31e91262ab63ce42b0cad1bdc33afd
parent2399c5808f1df80712f91e7570ed6ca6abb48b6f
EVM: Use crypto_memneq() for digest comparisons

commit 613317bd212c585c20796c10afe5daaa95d4b0a1 upstream.

This patch fixes vulnerability CVE-2016-2085.  The problem exists
because the vm_verify_hmac() function includes a use of memcmp().
Unfortunately, this allows timing side channel attacks; specifically
a MAC forgery complexity drop from 2^128 to 2^12.  This patch changes
the memcmp() to the cryptographically safe crypto_memneq().

Reported-by: Xiaofei Rex Guo <xiaofei.rex.guo@intel.com>
Signed-off-by: Ryan Ware <ware@linux.intel.com>
Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
security/integrity/evm/evm_main.c