]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: pvrusb2: Fix oops on tear-down when radio support is not present
authorMike Isely <isely@pobox.com>
Wed, 6 Nov 2019 11:11:14 +0000 (12:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 Jan 2020 12:39:49 +0000 (13:39 +0100)
commit61d8117f13976bcb4e70c4c52509238b5efc8354
treee07411ee691d72988c79217f0a65b73861f4868a
parent807185ff15b4562ba8b006fb59ced23f0376b946
media: pvrusb2: Fix oops on tear-down when radio support is not present

[ Upstream commit 7f404ae9cf2a285f73b3c18ab9303d54b7a3d8e1 ]

In some device configurations there's no radio or radio support in the
driver.  That's OK, as the driver sets itself up accordingly.  However
on tear-down in these caes it's still trying to tear down radio
related context when there isn't anything there, leading to
dereferences through a null pointer and chaos follows.

How this bug survived unfixed for 11 years in the pvrusb2 driver is a
mystery to me.

[hverkuil: fix two checkpatch warnings]

Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/usb/pvrusb2/pvrusb2-v4l2.c