]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nfsd: restore callback functionality for NFSv4.0
authorNeilBrown <neilb@suse.de>
Fri, 20 Dec 2024 04:28:18 +0000 (15:28 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Jan 2025 09:30:48 +0000 (10:30 +0100)
commit61ddaac44efaaeabee2a186ec368ad58f0866e69
tree9004e098eca99c4a7b4f8364b0cad2d74af148d4
parent9a57119d1182f4d50bb3b2d868345bca6b4e00de
nfsd: restore callback functionality for NFSv4.0

[ Upstream commit 7917f01a286ce01e9c085e24468421f596ee1a0c ]

A recent patch inadvertently broke callbacks for NFSv4.0.

In the 4.0 case we do not expect a session to be found but still need to
call setup_callback_client() which will not try to dereference it.

This patch moves the check for failure to find a session into the 4.1+
branch of setup_callback_client()

Fixes: 1e02c641c3a4 ("NFSD: Prevent NULL dereference in nfsd4_process_cb_update()")
Signed-off-by: NeilBrown <neilb@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nfsd/nfs4callback.c