]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
eth: bnxt: fix counting packets discarded due to OOM and netpoll
authorJakub Kicinski <kuba@kernel.org>
Wed, 24 Apr 2024 00:21:48 +0000 (17:21 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 May 2024 14:32:39 +0000 (16:32 +0200)
commit62041d20f92eacddec4c9ec359757332ec5422bc
treed0918df64e43f5897e1ddc148bd37d8a313d83b5
parentde1aaefa75be9d0ec19c9a3e0e2f9696de20c6ab
eth: bnxt: fix counting packets discarded due to OOM and netpoll

[ Upstream commit 730117730709992c9f6535dd7b47638ee561ec45 ]

I added OOM and netpoll discard counters, naively assuming that
the cpr pointer is pointing to a common completion ring.
Turns out that is usually *a* completion ring but not *the*
completion ring which bnapi->cp_ring points to. bnapi->cp_ring
is where the stats are read from, so we end up reporting 0
thru ethtool -S and qstat even though the drop events have happened.
Make 100% sure we're recording statistics in the correct structure.

Fixes: 907fd4a294db ("bnxt: count discards due to memory allocation errors")
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Link: https://lore.kernel.org/r/20240424002148.3937059-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c