]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MINOR: quic-sock: do not double free session on conn init failure
authorAmaury Denoyelle <adenoyelle@haproxy.com>
Wed, 13 Apr 2022 14:58:26 +0000 (16:58 +0200)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Thu, 14 Apr 2022 12:50:12 +0000 (14:50 +0200)
commit622ec4166b8d755a9dde9cd3024a2046dd555a48
tree14c9f75c81f7e4cca41924245972c36475a487f6
parent2461bd534a1639775b2264a2f307e9684a912fc0
BUG/MINOR: quic-sock: do not double free session on conn init failure

In the quic_session_accept, connection is in charge to call the
quic-conn start callback. If this callback fails for whatever reason,
there is a crash because of an explicit session_free.

This happens because the connection is now the owner of the session due
to previous conn_complete_session call. It will automatically calls
session_free. Fix this by skipping the session_free explicit invocation
on error.

In practice, currently this has never happened as there is only limited
cases of failures for conn_xprt_start for QUIC.
src/quic_sock.c