]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nfs: fix memory leak in error path of nfs4_do_reclaim
authorLi Lingfeng <lilingfeng3@huawei.com>
Wed, 4 Sep 2024 12:34:57 +0000 (20:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Oct 2024 13:11:15 +0000 (15:11 +0200)
commit62356668d855deb075a93fdf9f26888c4f80b7d6
tree33efcdf0d10ba640d847b6f43d992612b2a07993
parent394584185c76494437067217e594a4a8d705419d
nfs: fix memory leak in error path of nfs4_do_reclaim

commit 8f6a7c9467eaf39da4c14e5474e46190ab3fb529 upstream.

Commit c77e22834ae9 ("NFSv4: Fix a potential sleep while atomic in
nfs4_do_reclaim()") separate out the freeing of the state owners from
nfs4_purge_state_owners() and finish it outside the rcu lock.
However, the error path is omitted. As a result, the state owners in
"freeme" will not be released.
Fix it by adding freeing in the error path.

Fixes: c77e22834ae9 ("NFSv4: Fix a potential sleep while atomic in nfs4_do_reclaim()")
Signed-off-by: Li Lingfeng <lilingfeng3@huawei.com>
Cc: stable@vger.kernel.org # v5.3+
Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfs/nfs4state.c