]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
UBIFS: do not read flash unnecessarily
authorArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Fri, 25 Mar 2011 16:33:57 +0000 (18:33 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 14 Apr 2011 20:02:20 +0000 (13:02 -0700)
commit623ec9f6000b2f61bae3a4b31181ac7258569a55
tree4a63f13681487d454a0bec222cf7f9add290804b
parent49e6fc727d1621fc084df4dd7f53dec7a2448f9a
UBIFS: do not read flash unnecessarily

commit 8b229c76765816796eec7ccd428f03bd8de8b525 upstream.

This fix makes the 'dbg_check_old_index()' function return
immediately if debugging is disabled, instead of executing
incorrect 'goto out' which causes UBIFS to:

1. Allocate memory
2. Read the flash

On every commit. OK, we do not commit that often, but it is
still silly to do unneeded I/O anyway.

Credits to coverity for spotting this silly issue.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/ubifs/commit.c