]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: SOF: ipc4-pcm: Fix incorrect comparison with number of tdm_slots
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Tue, 19 Aug 2025 16:05:25 +0000 (17:05 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 18 Sep 2025 21:23:57 +0000 (22:23 +0100)
commit62a7b3bbb6b873fdcc85a37efbd0102d66c8a73e
tree99a3f484c05fb557eeefbf52107a5d6a77191f76
parent1dd28fd86c3fa4e395031dd6f2ba920242107010
ASoC: SOF: ipc4-pcm: Fix incorrect comparison with number of tdm_slots

In ipc4_ssp_dai_config_pcm_params_match() when comparing params_channels()
against hw_config->tdm_slots the comparison should be a <= not a ==.

The number of TDM slots must be enough for the number of required channels.
But it can be greater. There are various reason why a I2S/TDM link has more
TDM slots than a particular audio stream needs.

The original comparison would fail on systems that had more TDM slots.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 8a07944a77e9 ("ASoC: SOF: ipc4-pcm: Look for best matching hw_config for SSP")
Link: https://patch.msgid.link/20250819160525.423416-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc4-pcm.c