]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: cpsw_new: Fix unnecessary netdev unregistration in cpsw_probe() error path
authorKevin Hao <haokexin@gmail.com>
Thu, 5 Feb 2026 02:47:02 +0000 (10:47 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 6 Feb 2026 02:51:20 +0000 (18:51 -0800)
commit62db84b7efa63b78aed9fdbdae90f198771be94c
treeb34661d8e63b3ed9e6e74c8f85db8e5e38549ea9
parentc9efde1e537baed7648a94022b43836a348a074f
net: cpsw_new: Fix unnecessary netdev unregistration in cpsw_probe() error path

The current error handling in cpsw_probe() has two issues:
- cpsw_unregister_ports() may be called before cpsw_register_ports() has
  been executed.

- cpsw_unregister_ports() is already invoked within cpsw_register_ports()
  in case of a register_netdev() failure, but the error path would call
  it again.

Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")
Signed-off-by: Kevin Hao <haokexin@gmail.com>
Cc: stable@vger.kernel.org
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Link: https://patch.msgid.link/20260205-cpsw-error-path-v1-1-6e58bae6b299@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ti/cpsw_new.c