]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/client: Do not pin in drm_client_buffer_vmap()
authorThomas Zimmermann <tzimmermann@suse.de>
Mon, 26 May 2025 13:25:17 +0000 (15:25 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 30 May 2025 07:47:27 +0000 (09:47 +0200)
commit62e1e11a4916cb7d6e6b5e18347e8cfae5e06e57
treefff8f761289fa21ac45afa5c3804f289176b11fb
parent2271e0a20ef795838527815e057f5af206b69c87
drm/client: Do not pin in drm_client_buffer_vmap()

Pin and vmap are two distict operations. Do not mix them.

The helper drm_client_buffer_vmap() maps the pages for fbdev-dma
and fbdev-shmem. In both cases, the vmap operation ensures that
the pages are available until the vunmap happens. And as the pages
in DMA or SHMEM areas cannot be moved, there is no reason to call
pin. Hence remove the pin call.

Update drm_client_buffer_vunmap() accordingly.

v2:
- call 'locked' variants of GEM helpers (Dmitry)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Link: https://lore.kernel.org/r/20250526132634.531789-2-tzimmermann@suse.de
drivers/gpu/drm/drm_client.c