]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ata: libata-eh: Add ata_eh_set_lpm() WARN_ON_ONCE
authorNiklas Cassel <cassel@kernel.org>
Thu, 15 May 2025 13:56:24 +0000 (15:56 +0200)
committerDamien Le Moal <dlemoal@kernel.org>
Tue, 20 May 2025 09:20:40 +0000 (18:20 +0900)
commit62eef53ab5ede2dba18ce4c5e7d031e05ab74025
tree50e9dd9b8025fa09cd1efa9bf990257d91f81ec8
parent381d43b26282377a7e2f7ddfdd0147ad72353621
ata: libata-eh: Add ata_eh_set_lpm() WARN_ON_ONCE

link->lpm_policy is initialized to ATA_LPM_UNKNOWN in ata_eh_reset().

ata_eh_set_lpm() is then only called if
link->lpm_policy != ap->target_lpm_policy (after reset)

and then only if link->lpm_policy > ATA_LPM_MAX_POWER (before
revalidation).

This means that ata_eh_set_lpm() is currently never called with
policy == ATA_LPM_UNKNOWN.

Add a WARN_ON_ONCE so that it is more obvious from reading the code that
this function is never called with policy == ATA_LPM_UNKNOWN.

Signed-off-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
drivers/ata/libata-eh.c