]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netem: Update sch->q.qlen before qdisc_tree_reduce_backlog()
authorCong Wang <cong.wang@bytedance.com>
Tue, 4 Feb 2025 00:58:40 +0000 (16:58 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Feb 2025 09:05:01 +0000 (10:05 +0100)
commit6312555249082d6d8cc5321ff725df05482d8b83
tree2c58bab5ce7fad79e0ae7ca49ce935c8da7e4c9a
parente40cb34b7f247fe2e366fd192700d1b4f38196ca
netem: Update sch->q.qlen before qdisc_tree_reduce_backlog()

[ Upstream commit 638ba5089324796c2ee49af10427459c2de35f71 ]

qdisc_tree_reduce_backlog() notifies parent qdisc only if child
qdisc becomes empty, therefore we need to reduce the backlog of the
child qdisc before calling it. Otherwise it would miss the opportunity
to call cops->qlen_notify(), in the case of DRR, it resulted in UAF
since DRR uses ->qlen_notify() to maintain its active list.

Fixes: f8d4bc455047 ("net/sched: netem: account for backlog updates from child qdisc")
Cc: Martin Ottens <martin.ottens@fau.de>
Reported-by: Mingi Cho <mincho@theori.io>
Signed-off-by: Cong Wang <cong.wang@bytedance.com>
Link: https://patch.msgid.link/20250204005841.223511-4-xiyou.wangcong@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sched/sch_netem.c