]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
p54: Initialize extra_len in p54_tx_80211
authorJason Conti <jason.conti@gmail.com>
Thu, 7 Apr 2011 19:09:57 +0000 (21:09 +0200)
committerAndi Kleen <ak@linux.intel.com>
Thu, 28 Apr 2011 15:21:11 +0000 (08:21 -0700)
commit63201d75a4b0e92609642888aecc3b3dfc2e25d2
treed79d4af6fec9cdf502c3928ffd9edfd3adcf3469
parent0dc54b12b37bb287ec4ef606ed3cc346b818e682
p54: Initialize extra_len in p54_tx_80211

commit a6756da9eace8b4af73e9dea43f1fc2889224c94 upstream.

This patch fixes a very serious off-by-one bug in
the driver, which could leave the device in an
unresponsive state.

The problem was that the extra_len variable [used to
reserve extra scratch buffer space for the firmware]
was left uninitialized. Because p54_assign_address
later needs the value to reserve additional space,
the resulting frame could be to big for the small
device's memory window and everything would
immediately come to a grinding halt.

Reference: https://bugs.launchpad.net/bugs/722185

Acked-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: Jason Conti <jason.conti@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
drivers/net/wireless/p54/txrx.c