]> git.ipfire.org Git - thirdparty/openvpn.git/commit
ensure function declarations are compiled with their definitions
authorAntonio Quartulli <antonio@openvpn.net>
Sat, 11 Nov 2017 16:18:36 +0000 (00:18 +0800)
committerGert Doering <gert@greenie.muc.de>
Sat, 6 Oct 2018 16:00:48 +0000 (18:00 +0200)
commit632af53a515aa1570028f9f82e4b11ab7171f3a3
treefe0da3d244a8d78c644ab0b9c4cf37607dc5047f
parenta54f37d8b702378e3aa39e97b40c4dcca6ab402d
ensure function declarations are compiled with their definitions

Function prototypes should be included when compiling their
definitions so that it is clear to compilers and static
analyzers that they are not static.

This means that several declarations have to be moved to the
related header files which in turn have to be included by the
source files implementing them.

Generally speaking this also improves the coding style and
makes this code more consistent with the rest that already
follows this rule.

Cc: Steffan Karger <steffan@karger.me>
Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
Acked-by: Steffan Karger <steffan.karger@fox-it.com>
Message-Id: <20171111161836.23356-3-a@unstable.cc>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15820.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
17 files changed:
src/openvpn/crypto.h
src/openvpn/error.c
src/openvpn/forward.h
src/openvpn/fragment.c
src/openvpn/gremlin.c
src/openvpn/init.h
src/openvpn/lladdr.c
src/openvpn/manage.h
src/openvpn/mbuf.h
src/openvpn/misc.h
src/openvpn/mroute.h
src/openvpn/multi.h
src/openvpn/occ.h
src/openvpn/pf.h
src/openvpn/ping.h
src/openvpn/plugin.h
src/openvpn/socket.h