]> git.ipfire.org Git - thirdparty/qemu.git/commit
block: Drop bdrv_ioctl_bh_cb
authorFam Zheng <famz@redhat.com>
Wed, 1 Jun 2016 01:52:23 +0000 (09:52 +0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 5 Aug 2016 18:33:39 +0000 (13:33 -0500)
commit63a396d1510084c7349f1e90ab9eb31b6ddb5718
treeb193580343dd36524f6da17ad67832bc680732be
parentf882993a8c1de20db98216ae0ed964d1f1a09307
block: Drop bdrv_ioctl_bh_cb

Similar to the "!drv || !drv->bdrv_aio_ioctl" case above, here it is
okay to set co.ret and return. As pointed out by Paolo, a BH will be
created as necessary by the caller (bdrv_co_maybe_schedule_bh).
Besides, as pointed out by Kevin, "data" was leaked before.

Reported-by: Kevin Wolf <kwolf@redhat.com>
Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20160601015223.19277-1-famz@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
(cherry picked from commit c8a9fd80719e63615dac12e3625223fb54aa8430)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block/io.c