]> git.ipfire.org Git - thirdparty/linux.git/commit
platform/chrome: cros_hps_i2c: Discard pm_runtime_put() return value
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 22 Dec 2025 20:27:44 +0000 (21:27 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 8 Jan 2026 20:36:51 +0000 (21:36 +0100)
commit6401e43479a809b7a5a930d76c363f4b5705ed00
treeb28ed4e97f9d769c71652d64c180c1f1b479edb1
parent01eafccacc707da2db2a9eb4be56c9367e42323f
platform/chrome: cros_hps_i2c: Discard pm_runtime_put() return value

Passing pm_runtime_put() return value to the callers is not particularly
useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.  It also happens when the kernel is
configured with CONFIG_PM unset.

Accordingly, update hps_release() to simply discard the return value of
pm_runtime_put() and always return success to the caller.

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://patch.msgid.link/2302270.NgBsaNRSFp@rafael.j.wysocki
drivers/platform/chrome/cros_hps_i2c.c