]> git.ipfire.org Git - thirdparty/linux.git/commit
apparmor: avoid per-cpu hold underflow in aa_get_buffer
authorZhengmian Hu <huzhengmian@gmail.com>
Tue, 20 Jan 2026 00:03:07 +0000 (19:03 -0500)
committerJohn Johansen <john.johansen@canonical.com>
Thu, 29 Jan 2026 09:27:55 +0000 (01:27 -0800)
commit640cf2f09575c9dc344b3f7be2498d31e3923ead
tree78de8b71fc7d0d00938aa2788d13892cef173c1c
parent796c146fa6c8289afc9e18004c21bfe05c75a487
apparmor: avoid per-cpu hold underflow in aa_get_buffer

When aa_get_buffer() pulls from the per-cpu list it unconditionally
decrements cache->hold. If hold reaches 0 while count is still non-zero,
the unsigned decrement wraps to UINT_MAX. This keeps hold non-zero for a
very long time, so aa_put_buffer() never returns buffers to the global
list, which can starve other CPUs and force repeated kmalloc(aa_g_path_max)
allocations.

Guard the decrement so hold never underflows.
Fixes: ea9bae12d028 ("apparmor: cache buffers on percpu list if there is lock contention")
Signed-off-by: Zhengmian Hu <huzhengmian@gmail.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
security/apparmor/lsm.c