]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: caam - fix RNG buffer cache alignment
authorSteve Cornelius <steve.cornelius@freescale.com>
Mon, 15 Jun 2015 23:52:59 +0000 (16:52 -0700)
committerSasha Levin <sasha.levin@oracle.com>
Wed, 1 Jul 2015 19:34:44 +0000 (15:34 -0400)
commit6429e7067cf74aba03bf368e2edb9756cc76b0ee
treeeb7e73061da5c160fcbf90ea8071cfdb5d6ea011
parent431685c80c5c8d465879177f18ba132f202ab87e
crypto: caam - fix RNG buffer cache alignment

[ Upstream commit 412c98c1bef65fe7589f1300e93735d96130307c ]

The hwrng output buffers (2) are cast inside of a a struct (caam_rng_ctx)
allocated in one DMA-tagged region. While the kernel's heap allocator
should place the overall struct on a cacheline aligned boundary, the 2
buffers contained within may not necessarily align. Consenquently, the ends
of unaligned buffers may not fully flush, and if so, stale data will be left
behind, resulting in small repeating patterns.

This fix aligns the buffers inside the struct.

Note that not all of the data inside caam_rng_ctx necessarily needs to be
DMA-tagged, only the buffers themselves require this. However, a fix would
incur the expense of error-handling bloat in the case of allocation failure.

Cc: stable@vger.kernel.org
Signed-off-by: Steve Cornelius <steve.cornelius@freescale.com>
Signed-off-by: Victoria Milhoan <vicki.milhoan@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/crypto/caam/caamrng.c