]> git.ipfire.org Git - thirdparty/linux.git/commit
ALSA: lx6464es: fix period byte count for 16-bit streams
authorXu Rao <raoxu@uniontech.com>
Thu, 23 Jul 2026 08:57:10 +0000 (16:57 +0800)
committerTakashi Iwai <tiwai@suse.de>
Sun, 26 Jul 2026 06:53:06 +0000 (08:53 +0200)
commit6437033bffe8bd2af174d139af552d90d40c7ac6
tree20c138043d72bed642f165e28fb7059b3fda1853
parent21e19688433452dfbbbe6b2bb670dea6eb92f0f6
ALSA: lx6464es: fix period byte count for 16-bit streams

The lx6464es driver advertises both 16-bit and packed 24-bit PCM formats,
but lx_trigger_start() and lx_interrupt_request_new_buffer() calculate the
DMA period size as runtime->period_size * runtime->channels * 3.  That is
only correct for the packed 24-bit formats.

For 16-bit streams the driver submits buffers that are 50% larger than the
actual ALSA period and advances the DMA address by the same wrong amount.
For example, with 2 channels, 256 frames and 4 periods, the third buffer
already extends beyond the ALSA buffer and the fourth buffer starts outside
it.

Use snd_pcm_lib_period_bytes() so the byte count matches the runtime
format, channel count and period size.

Fixes: 02bec4904508 ("ALSA: lx6464es - driver for the digigram lx6464es interface")
Cc: stable@vger.kernel.org
Signed-off-by: Xu Rao <raoxu@uniontech.com>
Link: https://patch.msgid.link/8BB12E8D92A7CDBA+20260723085710.2567463-1-raoxu@uniontech.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/lx6464es/lx6464es.c
sound/pci/lx6464es/lx_core.c