]> git.ipfire.org Git - thirdparty/linux.git/commit
platform/mellanox: mlxreg-lc: Fix logic error in power state check
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Mon, 30 Jun 2025 10:58:08 +0000 (03:58 -0700)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 30 Jun 2025 11:06:55 +0000 (14:06 +0300)
commit644bec18e705ca41d444053407419a21832fcb2f
treeaa6f94bd9adcd7acbb443910863355152bf8fca8
parentaf14ed3fcb2703d1185bf10531fee87e6e1cc60b
platform/mellanox: mlxreg-lc: Fix logic error in power state check

Fixes a logic issue in mlxreg_lc_completion_notify() where the
intention was to check if MLXREG_LC_POWERED flag is not set before
powering on the device.

The original code used "state & ~MLXREG_LC_POWERED" to check for the
absence of the POWERED bit. However this condition evaluates to true
even when other bits are set, leading to potentially incorrect
behavior.

Corrected the logic to explicitly check for the absence of
MLXREG_LC_POWERED using !(state & MLXREG_LC_POWERED).

Fixes: 62f9529b8d5c ("platform/mellanox: mlxreg-lc: Add initial support for Nvidia line card devices")
Suggested-by: Vadim Pasternak <vadimp@nvidia.com>
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Link: https://lore.kernel.org/r/20250630105812.601014-1-alok.a.tiwari@oracle.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/mellanox/mlxreg-lc.c