]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix ALTER DOMAIN VALIDATE CONSTRAINT locking
authorFujii Masao <fujii@postgresql.org>
Thu, 18 Jun 2026 01:19:15 +0000 (10:19 +0900)
committerFujii Masao <fujii@postgresql.org>
Thu, 18 Jun 2026 01:19:15 +0000 (10:19 +0900)
commit64797ad97d6e0a476f809979df99e0013c1933b1
treeee198fd794ca5cd8c94cb7e279d42fa13a411043
parent62c09cdc16757da93c373a197ec51a52b14bc2b3
Fix ALTER DOMAIN VALIDATE CONSTRAINT locking

Commit 16a0039dc0d1 reduced the lock level for ALTER DOMAIN ...
VALIDATE CONSTRAINT from ShareLock to ShareUpdateExclusiveLock.
However, that change was unsafe. If DML on tables using the domain had
already started and initialized domain constraint checks before a NOT
VALID constraint was added, it could still insert or update rows that
violated the new constraint.

This commit reverts commit 16a0039dc0d1 so that ALTER DOMAIN ...
VALIDATE CONSTRAINT once again acquires ShareLock on relations using
the domain. Also add an isolation test covering this case.

Author: Chao Li <lic@highgo.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/463C0E1A-4A40-4BCA-839C-9236B80D65EE@gmail.com
src/backend/commands/typecmds.c
src/test/isolation/expected/alter-domain-validate.out [new file with mode: 0644]
src/test/isolation/isolation_schedule
src/test/isolation/specs/alter-domain-validate.spec [new file with mode: 0644]