]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iio: dac: mcp4725: add missing powerdown bits in store eeprom
authorJean-Francois Dagenais <jeff.dagenais@gmail.com>
Wed, 6 Mar 2019 20:56:06 +0000 (15:56 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 13 Aug 2019 11:38:42 +0000 (12:38 +0100)
commit64b2f2b04918e7e05f5286166e819238fc12a626
tree9e2dbd29421303f26a1ae440866d898e7d99e142
parent520f412b3694a260bd9a75a7146895ff150054e9
iio: dac: mcp4725: add missing powerdown bits in store eeprom

commit 06003531502d06bc89d32528f6ec96bf978790f9 upstream.

When issuing the write DAC register and write eeprom command, the two
powerdown bits (PD0 and PD1) are assumed by the chip to be present in
the bytes sent. Leaving them at 0 implies "powerdown disabled" which is
a different state that the current one. By adding the current state of
the powerdown in the i2c write, the chip will correctly power-on exactly
like as it is at the moment of store_eeprom call.

This is documented in MCP4725's datasheet, FIGURE 6-2: "Write Commands
for DAC Input Register and EEPROM" and MCP4726's datasheet, FIGURE 6-3:
"Write All Memory Command".

Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Acked-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/iio/dac/mcp4725.c