]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
KVM: ARM: vgic: plug irq injection race
authorMarc Zyngier <marc.zyngier@arm.com>
Tue, 8 Jul 2014 11:09:00 +0000 (12:09 +0100)
committerJiri Slaby <jslaby@suse.cz>
Thu, 30 Apr 2015 09:15:10 +0000 (11:15 +0200)
commit64b4f742f29eb19cd8c669703de4102a67228076
tree310296dc8ec13a1c0eb6b2be4a1d7f0bc7abdb37
parent5db2afbfd7ec7e9188481f8e26ada8b4bba8144c
KVM: ARM: vgic: plug irq injection race

commit 71afaba4a2e98bb7bdeba5078370ab43d46e67a1 upstream.

As it stands, nothing prevents userspace from injecting an interrupt
before the guest's GIC is actually initialized.

This goes unnoticed so far (as everything is pretty much statically
allocated), but ends up exploding in a spectacular way once we switch
to a more dynamic allocation (the GIC data structure isn't there yet).

The fix is to test for the "ready" flag in the VGIC distributor before
trying to inject the interrupt. Note that in order to avoid breaking
userspace, we have to ignore what is essentially an error.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
virt/kvm/arm/vgic.c