]> git.ipfire.org Git - thirdparty/git.git/commit
test-lib-functions: use test-tool for [de]packetize()
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Fri, 16 Jul 2021 15:41:33 +0000 (17:41 +0200)
committerJunio C Hamano <gitster@pobox.com>
Mon, 19 Jul 2021 18:53:50 +0000 (11:53 -0700)
commit64f0109f17ecfdd504f497b67cc066b672e00dc5
tree6de133c4f368f5358a46b395a4bb50bf591dfefd
parentebf3c04b262aa27fbb97f8a0156c2347fecafafb
test-lib-functions: use test-tool for [de]packetize()

The shell+perl "[de]packetize()" helper functions were added in
4414a150025 (t/lib-git-daemon: add network-protocol helpers,
2018-01-24), and around the same time we added the "pkt-line" helper
in 74e70029615 (test-pkt-line: introduce a packet-line test helper,
2018-03-14).

For some reason it seems we've mostly used the shell+perl version
instead of the helper since then. There were discussions around
88124ab2636 (test-lib-functions: make packetize() more efficient,
2020-03-27) and cacae4329fa (test-lib-functions: simplify packetize()
stdin code, 2020-03-29) to improve them and make them more efficient.

There was one good reason to do so, we needed an equivalent of
"test-tool pkt-line pack", but that command wasn't capable of handling
input with "\n" (a feature) or "\0" (just because it happens to be
printf-based under the hood).

Let's add a "pkt-line-raw" helper for that, and expose is at a
packetize_raw() to go with the existing packetize() on the shell
level, this gives us the smallest amount of change to the tests
themselves.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/helper/test-pkt-line.c
t/t5411/once-0010-report-status-v1.sh
t/t5562-http-backend-content-length.sh
t/t5570-git-daemon.sh
t/test-lib-functions.sh