]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
qlcnic: dcb: default to returning -EOPNOTSUPP
authorTom Rix <trix@redhat.com>
Sat, 26 Mar 2022 17:20:03 +0000 (10:20 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 07:06:37 +0000 (09:06 +0200)
commit64f70e92a7254a1614e045b97029bbb82bf8fe64
treecf5c85ec763d873313f10969c9518394e2e85354
parenta61b5b2ff23a64dc8ad555d928912ee7f183f2f1
qlcnic: dcb: default to returning -EOPNOTSUPP

[ Upstream commit 1521db37f0d42334a88e8ff28198a27d1ed5cd7b ]

Clang static analysis reports this issue
qlcnic_dcb.c:382:10: warning: Assigned value is
  garbage or undefined
  mbx_out = *val;
          ^ ~~~~

val is set in the qlcnic_dcb_query_hw_capability() wrapper.
If there is no query_hw_capability op in dcp, success is
returned without setting the val.

For this and similar wrappers, return -EOPNOTSUPP.

Fixes: 14d385b99059 ("qlcnic: dcb: Query adapter DCB capabilities.")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h