]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
MIPS: uprobes: remove incorrect set_orig_insn
authorMarcin Nowakowski <marcin.nowakowski@imgtec.com>
Thu, 22 Sep 2016 13:38:32 +0000 (15:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Oct 2016 13:21:20 +0000 (15:21 +0200)
commit65057b0f12254a2e821999d7cda9013c093aa931
treeb69ce1c1be9ad219fcb22f36c22d4957ab3f23b4
parent9dc902ebc0d98cdc9e3c9efbec72683add760c61
MIPS: uprobes: remove incorrect set_orig_insn

commit ddabfa5c2e33f1b495f3e0176de7057850915c0b upstream.

Generic kernel code implements a weak version of set_orig_insn that
moves cached 'insn' from arch_uprobe to the original code location when
the trap is removed.
MIPS variant used arch_uprobe->orig_inst which was never initialised
properly, so this code only inserted a nop instead of the original
instruction. With that change orig_inst can also be safely removed.

Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Fixes: 40e084a506eb ('MIPS: Add uprobes support.')
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/14299/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/mips/include/asm/uprobes.h
arch/mips/kernel/uprobes.c