]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
staging: axis-fifo: Correct handling of tx_fifo_depth for size validation
authorGabriel Shahrouzi <gshahrouzi@gmail.com>
Sat, 19 Apr 2025 01:29:37 +0000 (21:29 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 18 May 2025 06:21:22 +0000 (08:21 +0200)
commit651d9b7d478a17738267e835d431704fe5d545e3
tree5e701bb275cccfbbc44349b7170ba198a0a75c92
parent0a73a6ac5ffc4988027c88df61adddf3582fffbf
staging: axis-fifo: Correct handling of tx_fifo_depth for size validation

commit 2ca34b508774aaa590fc3698a54204706ecca4ba upstream.

Remove erroneous subtraction of 4 from the total FIFO depth read from
device tree. The stored depth is for checking against total capacity,
not initial vacancy. This prevented writes near the FIFO's full size.

The check performed just before data transfer, which uses live reads of
the TDFV register to determine current vacancy, correctly handles the
initial Depth - 4 hardware state and subsequent FIFO fullness.

Fixes: 4a965c5f89de ("staging: add driver for Xilinx AXI-Stream FIFO v4.1 IP core")
Cc: stable@vger.kernel.org
Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com>
Link: https://lore.kernel.org/r/20250419012937.674924-1-gshahrouzi@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/axis-fifo/axis-fifo.c