]> git.ipfire.org Git - thirdparty/systemd.git/commit
core/timer: Always use inactive_exit_timestamp if it is set
authorDaan De Meyer <daan.j.demeyer@gmail.com>
Tue, 23 May 2023 14:24:47 +0000 (16:24 +0200)
committerDaan De Meyer <daan.j.demeyer@gmail.com>
Wed, 24 May 2023 08:05:08 +0000 (10:05 +0200)
commit6546045fa0bf84737bd8b2e1e8bf7dd3941d8352
tree8b5bd8361239b5ad983fbe14d00a3d262876d696
parent26a9dd6f55bb757e0033995cbb16bca12986b7cd
core/timer: Always use inactive_exit_timestamp if it is set

If we're doing a daemon-reload, we'll be going from TIMER_DEAD => TIMER_WAITING,
so we won't use inactive_exit_timestamp because TIMER_DEAD != UNIT_ACTIVE, even
though inactive_exit_timestamp is serialized/deserialized and will be valid after
the daemon-reload.

This issue can lead to timers never firing as we'll always calculate the next
elapse based on the current realtime on daemon-reload, so if daemon-reload happens
often enough, the elapse interval will be moved into the future every time, which
means the timer will never trigger.

To fix the issue, let's always use inactive_exit_timestamp if it is set, and only
fall back to the current realtime if it is not set.
src/core/timer.c