]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scripts: generate_rust_analyzer: add missing macros deps
authorTamir Duberstein <tamird@gmail.com>
Mon, 10 Feb 2025 17:03:24 +0000 (12:03 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Mar 2025 19:54:27 +0000 (12:54 -0700)
commit657f5e3eeceb6efa128927a599a9c2c2429d1260
tree9e5c2565a003b82a01cc4fc8642e49c500aa3e12
parent7c29e8fd1f0ebab275a069d6ee0365e19fe63471
scripts: generate_rust_analyzer: add missing macros deps

[ Upstream commit 2e0f91aba507a3cb59f7a12fc3ea2b7d4d6675b7 ]

The macros crate has depended on std and proc_macro since its
introduction in commit 1fbde52bde73 ("rust: add `macros` crate"). These
dependencies were omitted from commit 8c4555ccc55c ("scripts: add
`generate_rust_analyzer.py`") resulting in missing go-to-definition and
autocomplete, and false-positive warnings emitted from rust-analyzer
such as:

  [{
   "resource": "/Users/tamird/src/linux/rust/macros/module.rs",
   "owner": "_generated_diagnostic_collection_name_#1",
   "code": {
   "value": "non_snake_case",
   "target": {
   "$mid": 1,
   "path": "/rustc/",
   "scheme": "https",
   "authority": "doc.rust-lang.org",
   "query": "search=non_snake_case"
   }
   },
   "severity": 4,
   "message": "Variable `None` should have snake_case name, e.g. `none`",
   "source": "rust-analyzer",
   "startLineNumber": 123,
   "startColumn": 17,
   "endLineNumber": 123,
   "endColumn": 21
  }]

Add the missing dependencies to improve the developer experience.

  [ Fiona had a different approach (thanks!) at:

        https://lore.kernel.org/rust-for-linux/20241205115438.234221-1-me@kloenk.dev/

    But Tamir and Fiona agreed to this one. - Miguel ]

Fixes: 8c4555ccc55c ("scripts: add `generate_rust_analyzer.py`")
Reviewed-by: Fiona Behrens <me@kloenk.dev>
Diagnosed-by: Chayim Refael Friedman <chayimfr@gmail.com>
Link: https://github.com/rust-lang/rust-analyzer/issues/17759#issuecomment-2646328275
Signed-off-by: Tamir Duberstein <tamird@gmail.com>
Tested-by: Andreas Hindborg <a.hindborg@kernel.org>
Link: https://lore.kernel.org/r/20250210-rust-analyzer-macros-core-dep-v3-1-45eb4836f218@gmail.com
[ Removed `return`. Changed tag name. Added Link. Slightly
  reworded. - Miguel ]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
scripts/generate_rust_analyzer.py