]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rcu-tasks: Fix show_rcu_tasks_trace_gp_kthread buffer overflow
authorNikita Kiryushin <kiryushin@ancud.ru>
Wed, 27 Mar 2024 17:47:47 +0000 (20:47 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 May 2024 07:48:58 +0000 (09:48 +0200)
commit6593d857ce5b5b802fb73d8091ac9c84b92c1697
tree986a1fe5d6d8fd1fd07fb044d013d9a15dc2b08f
parentfea4aea0fbc3d1481f689e8dbe0cac52102da755
rcu-tasks: Fix show_rcu_tasks_trace_gp_kthread buffer overflow

[ Upstream commit cc5645fddb0ce28492b15520306d092730dffa48 ]

There is a possibility of buffer overflow in
show_rcu_tasks_trace_gp_kthread() if counters, passed
to sprintf() are huge. Counter numbers, needed for this
are unrealistically high, but buffer overflow is still
possible.

Use snprintf() with buffer size instead of sprintf().

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: edf3775f0ad6 ("rcu-tasks: Add count for idle tasks on offline CPUs")
Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/rcu/tasks.h