]> git.ipfire.org Git - thirdparty/linux.git/commit
net: rose: fix invalid array index in rose_kill_by_device()
authorPwnverse <stanksal@purdue.edu>
Mon, 22 Dec 2025 21:22:27 +0000 (21:22 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 30 Dec 2025 10:45:51 +0000 (11:45 +0100)
commit6595beb40fb0ec47223d3f6058ee40354694c8e4
tree352e303a53e2ce3608a7ec559b7c972d780a9db0
parent5939b6dbcda8b0f5f03a8e5179c13dc0195eb6cd
net: rose: fix invalid array index in rose_kill_by_device()

rose_kill_by_device() collects sockets into a local array[] and then
iterates over them to disconnect sockets bound to a device being brought
down.

The loop mistakenly indexes array[cnt] instead of array[i]. For cnt <
ARRAY_SIZE(array), this reads an uninitialized entry; for cnt ==
ARRAY_SIZE(array), it is an out-of-bounds read. Either case can lead to
an invalid socket pointer dereference and also leaks references taken
via sock_hold().

Fix the index to use i.

Fixes: 64b8bc7d5f143 ("net/rose: fix races in rose_kill_by_device()")
Co-developed-by: Fatma Alwasmi <falwasmi@purdue.edu>
Signed-off-by: Fatma Alwasmi <falwasmi@purdue.edu>
Signed-off-by: Pwnverse <stanksal@purdue.edu>
Link: https://patch.msgid.link/20251222212227.4116041-1-ritviktanksalkar@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/rose/af_rose.c