]> git.ipfire.org Git - thirdparty/gcc.git/commit
c++: Don't reject calls through PMF during constant evaluation [PR102786]
authorJakub Jelinek <jakub@redhat.com>
Tue, 19 Oct 2021 07:24:57 +0000 (09:24 +0200)
committerJakub Jelinek <jakub@redhat.com>
Wed, 11 May 2022 05:58:30 +0000 (07:58 +0200)
commit662de049d63759b731bed62f9df60edb47120658
tree94ec32a4d01fd13d05e6f6c47bb386c7f360b35b
parentbe2c01c63459e21f8a6da1e9c9933fdadd76eee5
c++: Don't reject calls through PMF during constant evaluation [PR102786]

The following testcase incorrectly rejects the c initializer,
while in the s.*a case cxx_eval_* sees .__pfn reads etc.,
in the s.*&S::foo case get_member_function_from_ptrfunc creates
expressions which use INTEGER_CSTs with type of pointer to METHOD_TYPE.
And cxx_eval_constant_expression rejects any INTEGER_CSTs with pointer
type if they aren't 0.
Either we'd need to make sure we defer such folding till cp_fold but the
function and pfn_from_ptrmemfunc is used from lots of places, or
the following patch just tries to reject only non-zero INTEGER_CSTs
with pointer types if they don't point to METHOD_TYPE in the hope that
all such INTEGER_CSTs with POINTER_TYPE to METHOD_TYPE are result of
folding valid pointer-to-member function expressions.
I don't immediately see how one could create such INTEGER_CSTs otherwise,
cast of integers to PMF is rejected and would have the PMF RECORD_TYPE
anyway, etc.

2021-10-19  Jakub Jelinek  <jakub@redhat.com>

PR c++/102786
* constexpr.c (cxx_eval_constant_expression): Don't reject
INTEGER_CSTs with type POINTER_TYPE to METHOD_TYPE.

* g++.dg/cpp2a/constexpr-virtual19.C: New test.

(cherry picked from commit f45610a45236e97616726ca042898d6ac46a082e)
gcc/cp/constexpr.c
gcc/testsuite/g++.dg/cpp2a/constexpr-virtual19.C [new file with mode: 0644]