]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
nilfs2: fix backing_dev_info reference leak
authorShuangpeng Bai <shuangpeng.kernel@gmail.com>
Thu, 7 May 2026 15:50:21 +0000 (11:50 -0400)
committerViacheslav Dubeyko <slava@dubeyko.com>
Fri, 8 May 2026 18:06:55 +0000 (11:06 -0700)
commit665f192a2a11384cb7dc1be5f87d16438522a4ed
treebacc76fba09283ddcefd20fc16df3346df878d75
parent0e7a690fe435f8d5ea3feb7c1d8d73ba7e8b8aa9
nilfs2: fix backing_dev_info reference leak

setup_bdev_super() already initializes sb->s_bdev and takes a
reference on the block device backing_dev_info when assigning sb->s_bdi.

nilfs_fill_super() takes another reference to the same
backing_dev_info and stores it in sb->s_bdi again. The extra
reference is not paired with a matching bdi_put(), since
generic_shutdown_super() releases sb->s_bdi only once.

Drop the redundant bdi_get() in nilfs_fill_super(). The single
reference taken by setup_bdev_super() is enough and is released
during superblock shutdown.

Fixes: c1e012ea9e83 ("nilfs2: use setup_bdev_super to de-duplicate the mount code")
Signed-off-by: Shuangpeng Bai <shuangpeng.kernel@gmail.com>
Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com>
Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
fs/nilfs2/super.c