]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netfilter: nf_tables: Keep deleted flowtable hooks until after RCU
authorPhil Sutter <phil@nwl.cc>
Thu, 12 Sep 2024 12:21:33 +0000 (14:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:29:42 +0000 (16:29 +0200)
commit668f4df6d6df17330e35f434b1f0633709f5fb33
tree7a4159becbebe0f1d985318a77bf64adb89be286
parent3e8ac2743d487c34af79d20a7615190b4e59e29d
netfilter: nf_tables: Keep deleted flowtable hooks until after RCU

[ Upstream commit 642c89c475419b4d0c0d90e29d9c1a0e4351f379 ]

Documentation of list_del_rcu() warns callers to not immediately free
the deleted list item. While it seems not necessary to use the
RCU-variant of list_del() here in the first place, doing so seems to
require calling kfree_rcu() on the deleted item as well.

Fixes: 3f0465a9ef02 ("netfilter: nf_tables: dynamically allocate hooks per net_device in flowtables")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/netfilter/nf_tables_api.c