]> git.ipfire.org Git - thirdparty/linux.git/commit
nfs: don't return AOP_WRITEPAGE_ACTIVATE from nfs_do_writepage
authorChristoph Hellwig <hch@lst.de>
Wed, 7 May 2025 04:48:52 +0000 (06:48 +0200)
committerAnna Schumaker <anna.schumaker@oracle.com>
Wed, 28 May 2025 21:17:13 +0000 (17:17 -0400)
commit66beed5acaf27137007459e7e53bf8d6f1b799cc
tree413a8f978bb0e053f93d26f2a390750af4252b78
parentb6354e60dd01d700a99d1f8c2f20d8ed530b0f45
nfs: don't return AOP_WRITEPAGE_ACTIVATE from nfs_do_writepage

nfs_do_writepage is a successful return that requires the caller to
unlock the folio.  Using it here requires special casing both in
nfs_do_writepage and nfs_writepages_callback and leaves a land mine in
nfs_wb_folio in case it ever set the flag.  Remove it and just
unconditionally unlock in nfs_writepages_callback.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
fs/nfs/write.c