]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
accel/amdxdna: fix open_ref leak and stale client pointer on dma map failure
authorLizhi Hou <lizhi.hou@amd.com>
Tue, 7 Jul 2026 05:56:58 +0000 (22:56 -0700)
committerLizhi Hou <lizhi.hou@amd.com>
Tue, 7 Jul 2026 17:04:34 +0000 (10:04 -0700)
commit66ff5c0eee02c4be67f8ba7fb6c63709ef1c92a3
treebce1a14e15f8b70aa887d223e8def6c3f3f2fa53
parent14f172eff9c19f8043a9858845f33cd034f3a41e
accel/amdxdna: fix open_ref leak and stale client pointer on dma map failure

amdxdna_gem_obj_open() increments open_ref before attempting to set up
the DMA address mapping.  When amdxdna_dma_map_bo() fails, the function
returned immediately without rolling back either change made on the first
open (open_ref == 1 path).

Fix it by decrementing open_ref and clearing abo->client on the error path.

Fixes: ece3e8980907 ("accel/amdxdna: Allow forcing IOVA-based DMA via module parameter")
Reviewed-by: Max Zhen <max.zhen@amd.com>
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Link: https://patch.msgid.link/20260707055658.479049-1-lizhi.hou@amd.com
drivers/accel/amdxdna/amdxdna_gem.c