]> git.ipfire.org Git - thirdparty/git.git/commit
scalar-diagnose: use 'git diagnose --mode=all'
authorVictoria Dye <vdye@github.com>
Fri, 12 Aug 2022 20:10:18 +0000 (20:10 +0000)
committerJunio C Hamano <gitster@pobox.com>
Fri, 12 Aug 2022 20:20:02 +0000 (13:20 -0700)
commit672196a3073036be2eda683fc116af9a21a66aa6
tree2402307e82bdf5652fa329dcf64e12121369acde
parentaac0e8ffeeed57cae2a047fd442f2125cbfc8e39
scalar-diagnose: use 'git diagnose --mode=all'

Replace implementation of 'scalar diagnose' with an internal invocation of
'git diagnose --mode=all'. This simplifies the implementation of
'cmd_diagnose' by making it a direct alias of 'git diagnose' and removes
some code in 'scalar.c' that is duplicated in 'builtin/diagnose.c'. The
simplicity of the alias also sets up a clean deprecation path for 'scalar
diagnose' (in favor of 'git diagnose'), if that is desired in the future.

This introduces one minor change to the output of 'scalar diagnose', which
is that the prefix of the created zip archive is changed from 'scalar_' to
'git-diagnostics-'.

Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Victoria Dye <vdye@github.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/scalar/scalar.c