]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
spi: spi-ti-qspi: Fix return value handling of wait_for_completion_timeout
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 11 Apr 2022 11:10:33 +0000 (11:10 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 14:59:19 +0000 (16:59 +0200)
commit674d414dd072ed20afdc9151d091a7232393ea7b
treec4611a73beed9cc2c4ca24ac4e6b2d9cd54547c7
parent6861aacff9a9f40746d197cf03f3a1ac9713bb71
spi: spi-ti-qspi: Fix return value handling of wait_for_completion_timeout

[ Upstream commit 8b1ea69a63eb62f97cef63e6d816b64ed84e8760 ]

wait_for_completion_timeout() returns unsigned long not int.
It returns 0 if timed out, and positive if completed.
The check for <= 0 is ambiguous and should be == 0 here
indicating timeout which is the only error case.

Fixes: 5720ec0a6d26 ("spi: spi-ti-qspi: Add DMA support for QSPI mmap read")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220411111034.24447-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-ti-qspi.c