]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix planner's row-mark code for inheritance from a foreign table.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 2 Jun 2021 18:38:14 +0000 (14:38 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 2 Jun 2021 18:38:14 +0000 (14:38 -0400)
commit6753a5b7e86cd9bb1eed580b1f9001d5ea1bbdb3
treeb32530587ee6b709d7f79c838b3c03400d2d23ff
parente5b0fffa17f610f03f03952c8c4a247c39e61292
Fix planner's row-mark code for inheritance from a foreign table.

Commit 428b260f8 broke planning of cases where row marks are needed
(SELECT FOR UPDATE, etc) and one of the query's tables is a foreign
table that has regular table(s) as inheritance children.  We got the
reverse case right, but apparently were thinking that foreign tables
couldn't be inheritance parents.  Not so; so we need to be able to
add a CTID junk column while adding a new child, not only a wholerow
junk column.

Back-patch to v12 where the faulty code came in.

Amit Langote

Discussion: https://postgr.es/m/CA+HiwqEmo3FV1LAQ4TVyS2h1WM=kMkZUmbNuZSCnfHvMcUcPeA@mail.gmail.com
contrib/postgres_fdw/expected/postgres_fdw.out
contrib/postgres_fdw/sql/postgres_fdw.sql
src/backend/optimizer/util/inherit.c