]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
scsi: esas2r: Fix __printf annotation on esas2r_log_master()
authorArnd Bergmann <arnd@arndb.de>
Mon, 23 Mar 2026 09:57:39 +0000 (10:57 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 27 Mar 2026 20:29:50 +0000 (16:29 -0400)
commit67557418905b103eaa7bacf81999be83accda334
treeec4c03cc0864515142b1d6d13414c2819ecae90c
parent8ad1ddc50d15e35c4b38a207a6856eddfa731194
scsi: esas2r: Fix __printf annotation on esas2r_log_master()

clang-22 started warning about functions that take printf format
strings:

drivers/scsi/esas2r/esas2r_log.c:160:50: error: diagnostic behavior may be improved by adding the 'format(printf, 3, 0)' attribute to the declaration of 'esas2r_log_master' [-Werror,-Wmissing-format-attribute]
  121 |                 retval = vsnprintf(buffer, buflen, format, args);
      |                                                                ^
drivers/scsi/esas2r/esas2r_log.c:121:12: note: 'esas2r_log_master' declared here
  121 | static int esas2r_log_master(const long level,
      |            ^

The warning already got silenced for gcc but not clang in the past.
Rather than modify that hack to turn it off for both, just add the
attribute as suggested and remove the pragma again.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Link: https://patch.msgid.link/20260323100027.1975646-1-arnd@kernel.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/esas2r/esas2r_log.c