]> git.ipfire.org Git - thirdparty/libvirt.git/commit
remote_daemon_dispatch: Check for limit properly in remoteDispatchConnectGetAllDomain...
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 27 Aug 2019 09:05:21 +0000 (11:05 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 28 Aug 2019 09:11:56 +0000 (11:11 +0200)
commit6763f42eee2e1bfd12c596777d25c9345042fba0
tree31e8c84171916903e2b98b42acfb77cfeae7fd76
parent3d1799192de9d4dd2fa14cb10ac0dbda23a6e305
remote_daemon_dispatch: Check for limit properly in remoteDispatchConnectGetAllDomainStats

The return structure is a bit complicated and that's why it is
very easy to check for RPC limits incorrectly. The structure is
an array of remote_domain_stats_record structures with the limit
of REMOTE_DOMAIN_LIST_MAX. The latter structure then poses a
different limit on typed params:
REMOTE_CONNECT_GET_ALL_DOMAIN_STATS_MAX (which is what we are
checking for mistakenly).

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
src/remote/remote_daemon_dispatch.c