]> git.ipfire.org Git - thirdparty/linux.git/commit
block: fix bio_alloc_bioset slowpath GFP handling
authorVasily Gorbik <gor@linux.ibm.com>
Sun, 22 Mar 2026 02:35:10 +0000 (03:35 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 23 Mar 2026 13:58:32 +0000 (07:58 -0600)
commit67807fbaf12719fca46a622d759484652b79c7c3
treef85bf87728fc6e080f30caeaa6020f3ef5899c3e
parent24d4c90286b9a36a2b72d1e0ceeae237d427f975
block: fix bio_alloc_bioset slowpath GFP handling

bio_alloc_bioset() first strips __GFP_DIRECT_RECLAIM from the optimistic
fast allocation attempt with try_alloc_gfp(). If that fast path fails,
the slowpath checks saved_gfp to decide whether blocking allocation is
allowed, but then still calls mempool_alloc() with the stripped gfp mask.
That can lead to a NULL bio pointer being passed into bio_init().

Fix the slowpath by using saved_gfp for the bio and bvec mempool
allocations.

Fixes: b520c4eef83d ("block: split bio_alloc_bioset more clearly into a fast and slowpath")
Reported-by: syzbot+09ddb593eea76a158f42@syzkaller.appspotmail.com
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://patch.msgid.link/p01.gc6e9ad5845ad.ttca29g@ub.hpns
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bio.c