]> git.ipfire.org Git - thirdparty/git.git/commit
gitk: sanitize 'open' arguments: revisit recently updated 'open' calls
authorJohannes Sixt <j6t@kdbg.org>
Sat, 29 Mar 2025 17:49:05 +0000 (18:49 +0100)
committerTaylor Blau <me@ttaylorr.com>
Fri, 23 May 2025 21:04:23 +0000 (17:04 -0400)
commit67a128b91e25978a15f9f7e194d81b441d603652
treedcd4a2f763aa6fb8c1f6a8ad5874a8ed7a671323
parentd7bc50cece90c490b34a7137568d2c58db40807a
gitk: sanitize 'open' arguments: revisit recently updated 'open' calls

The previous commits bb5cb23daf75 (gitk: prevent overly long command
lines, 2023-01-24) rewrote a set of the 'open' calls substantially.
These were then later updated by 7dd272eca153 (gitk: escape file paths
before piping to git log, 2023-01-24) and d5d1b91e5327 (gitk: encode
arguments correctly with "open", 2025-03-07). In the preceding merge,
the conversions to a safe_open variant were undone to ensure that the
principal operation of the new 'open' calls is not modified by accident.

Since the 'open' calls now pass a redirection from a Tcl string as
stdin, convert the calls to 'safe_open_command_redirect'.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
gitk