]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
team: don't traverse port list using rcu in team_set_mac_address
authorJiri Pirko <jiri@resnulli.us>
Wed, 4 Mar 2015 07:36:31 +0000 (08:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Mar 2015 12:31:23 +0000 (13:31 +0100)
commit67b58fb7d3e7b1e393609e14d95d02a14d7328db
tree166c31d5b1d81c36ad462b12072984e98c0b5c4f
parentf15e90f9f297c4c2c22de0f5b8530cb9fe62f263
team: don't traverse port list using rcu in team_set_mac_address

[ Upstream commit 9215f437b85da339a7dfe3db6e288637406f88b2 ]

Currently the list is traversed using rcu variant. That is not correct
since dev_set_mac_address can be called which eventually calls
rtmsg_ifinfo_build_skb and there, skb allocation can sleep. So fix this
by remove the rcu usage here.

Fixes: 3d249d4ca7 "net: introduce ethernet teaming device"
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/team/team.c