]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ipv4: icmp: validate reply type before using icmp_pointers
authorRuide Cao <caoruide123@gmail.com>
Tue, 21 Apr 2026 04:16:31 +0000 (12:16 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 23 Apr 2026 18:40:08 +0000 (11:40 -0700)
commit67bf002a2d7387a6312138210d0bd06e3cf4879b
tree63281f284da7abcc472c0ed148a0f3366f5b7efc
parent7ebc650474bad55573eebe16854ed935ab262350
ipv4: icmp: validate reply type before using icmp_pointers

Extended echo replies use ICMP_EXT_ECHOREPLY as the outbound reply type.
That value is outside the range covered by icmp_pointers[], which only
describes the traditional ICMP types up to NR_ICMP_TYPES.

Avoid consulting icmp_pointers[] for reply types outside that range, and
use array_index_nospec() for the remaining in-range lookup. Normal ICMP
replies keep their existing behavior unchanged.

Fixes: d329ea5bd884 ("icmp: add response to RFC 8335 PROBE messages")
Cc: stable@kernel.org
Reported-by: Yuan Tan <yuantan098@gmail.com>
Reported-by: Yifan Wu <yifanwucs@gmail.com>
Reported-by: Juefei Pu <tomapufckgml@gmail.com>
Reported-by: Xin Liu <bird@lzu.edu.cn>
Signed-off-by: Ruide Cao <caoruide123@gmail.com>
Signed-off-by: Ren Wei <n05ec@lzu.edu.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/0dace90c01a5978e829ca741ef684dbd7304ce62.1776628519.git.caoruide123@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/icmp.c