]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
leds: leds-cros_ec: Skip LEDs without color components
authorThomas Weißschuh <linux@weissschuh.net>
Tue, 28 Oct 2025 15:31:03 +0000 (16:31 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:16:58 +0000 (10:16 +0100)
commit67bfbc5a558ce07cbdb99503cb4f02a343eabd2e
treeda363d3a788f56bf38d0f0b9f951bd430d52c3fc
parent2c3edc2b7aa39ea9898adfe92d5ee1ea89abfcea
leds: leds-cros_ec: Skip LEDs without color components

commit 4dbf066d965cd3299fb396f1375d10423c9c625c upstream.

A user reports that on their Lenovo Corsola Magneton with EC firmware
steelix-15194.270.0 the driver probe fails with EINVAL. It turns out
that the power LED does not contain any color components as indicated
by the following "ectool led power query" output:

Brightness range for LED 1:
        red     : 0x0
        green   : 0x0
        blue    : 0x0
        yellow  : 0x0
        white   : 0x0
        amber   : 0x0

The LED also does not react to commands sent manually through ectool and
is generally non-functional.

Instead of failing the probe for all LEDs managed by the EC when one
without color components is encountered, silently skip those.

Cc: stable@vger.kernel.org
Fixes: 8d6ce6f3ec9d ("leds: Add ChromeOS EC driver")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://patch.msgid.link/20251028-cros_ec-leds-no-colors-v1-1-ebe13a02022a@weissschuh.net
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/leds/leds-cros_ec.c