]> git.ipfire.org Git - thirdparty/openvpn.git/commit
buf_string_match_head_str: Fix Coverity issue 'Unsigned compared against 0'
authorFrank Lichtenheld <frank@lichtenheld.com>
Fri, 19 Jan 2024 12:03:41 +0000 (13:03 +0100)
committerGert Doering <gert@greenie.muc.de>
Fri, 19 Jan 2024 13:09:47 +0000 (14:09 +0100)
commit68b00a54e779325f4ac9d9416b4e85261f771c23
tree2a456313b4b18f59ff7ee8b181582af1a08ba462
parent7b1f2009ce9670e2e0ffea0c01b1c4922a2d4369
buf_string_match_head_str: Fix Coverity issue 'Unsigned compared against 0'

As Coverity says:
An unsigned value can never be negative, so this test will always
evaluate the same way.

Was changed from int to size_t in commit
7fc608da4ec388c9209bd009cd5053ac0ff7df38 which triggered warning,
but the check did not make sense before, either.

Change-Id: I64f094eeb0ca8c3953a94d742adf468faf27dab3
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
Message-Id: <20240119120341.22933-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28093.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit bc29bd6a3376158b73d069758122739fbf93c022)
src/openvpn/buffer.c