]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-95041: Fix several minor issues in syslog.openlog() (GH-95058)
authorSerhiy Storchaka <storchaka@gmail.com>
Tue, 26 Jul 2022 06:12:10 +0000 (09:12 +0300)
committerGitHub <noreply@github.com>
Tue, 26 Jul 2022 06:12:10 +0000 (09:12 +0300)
commit68c555a50a2b74731b0db0f4dcbf51b2c11d4853
tree7434e572690e0768def354b32a4f5b0cbeff840f
parent2ef73be891eb95064e268341e38e81d008add480
gh-95041: Fix several minor issues in syslog.openlog() (GH-95058)

* syslog_get_argv() swallows exceptions, but not in all cases.
* if ident is non UTF-8 encodable, syslog.openlog() fails after setting the
  global reference to ident. Now the C string saved internally in the previous
  call to openlog() points to the freed memory.
* PySys_Audit() can crash if ident is NULL.
* There may be a race condition with syslog.syslog(), because the global
  reference to ident is decrefed before setting the new value.
* Possible use of freed memory if syslog.openlog() is called while
  the GIL is released in syslog.syslog().
Modules/syslogmodule.c