]> git.ipfire.org Git - thirdparty/linux.git/commit
can: gs_usb: gs_usb_receive_bulk_callback(): resubmit URB on skb allocation failure
authorMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 9 Jul 2026 07:54:26 +0000 (09:54 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 29 Jul 2026 10:00:00 +0000 (12:00 +0200)
commit68c5724ecd159992f76edb7b57dc508a44c8b7da
treea8a60b4725f8ce58c2643aa754e7ef6576020503
parent26504844613fb44c7cab1c5f6fcff77861709baa
can: gs_usb: gs_usb_receive_bulk_callback(): resubmit URB on skb allocation failure

If the allocation of the SKB in gs_usb_receive_bulk_callback() fails, the
driver returns from the callback without resubmitting the URB in order to
receive further USB in URBs.

This results in a silent performance degradation which, if it occurs
repeatedly, results in starvation of USB in traffic.

Instead of returning immediately, try to resend the URB. If this also
fails, this is logged as an info message.

Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN devices")
Fixes: 26949ac935e3 ("can: gs_usb: add CAN-FD support")
Link: https://patch.msgid.link/20260709-gs_usb-resubmit-urb-v1-1-4dd40030cc84@pengutronix.de
Cc: stable@kernel.org
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/gs_usb.c